Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Coriolis Coriolis
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 23
    • Issues 23
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 7
    • Merge requests 7
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Coriolis VLSI EDA
  • CoriolisCoriolis
  • Merge requests
  • !10

etesian: Return NULL for out-of-bounds slice

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Myrtle Shah requested to merge shah/coriolis:diode-fix into devel Oct 30, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 1

This can occur when the placement area is not divisible by the slice height. There is a small slither at the top whose 'islice' is one outside of the _slices array. Return NULL as if y was outside the placement area.

Would appreciate some feedback if this is the correct approach or if there's a better solution here, like rejecting placement area heights not divisible by the slice height.

Edited Oct 30, 2021 by Myrtle Shah
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: diode-fix